Refactor language service #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkillerud
force-pushed
the
refactor-language-service
branch
from
d5073ad to
d7c7705
Compare
The internals of the language server are now more uniform. All parts are working on the same parsed data structure instead of being a mix of three different parsers. This refactor includes a private fork of vscode-css-languageservice. It holds the parser and link resolution, and some language features we either extend, modify, or forward. It's kept as a separate package to hopefully make it easier to keep up with upstream, and to send patches upstream as well. A goal with this refactor is to make it easier to maintain the codebase both for myself and for new contributors.
wkillerud
force-pushed
the
refactor-language-service
branch
3 times, most recently
from
eef647d to
a6d35c6
Compare
To save ourselves a build-step and make it easier to debug.
A goal is to make it easier for new contributors to get started.
wkillerud
force-pushed
the
refactor-language-service
branch
from
a6d35c6 to
3398d7b
Compare
These can come at times when the document is in a broken state, for instance bad links. Handle exceptions by swallowing them. The editor can always try again later.
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on Visual Studio Marketplace Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internals of the language server are now more uniform. All parts
are working on the same parsed data structure instead of being a mix
of three different parsers.
This refactor includes a private fork of vscode-css-languageservice.
It holds the parser and link resolution, and some language features
we either extend, modify, or forward. It's kept as a separate package
to hopefully make it easier to keep up with upstream, and to send
patches upstream as well.
The goal with this refactor is to pay down technical debt and make it
easier for new developers to become contributors.
The goal with the documentation is to help users get the most out of
Some Sass and to help attract and onboard new contributors.